planner: fix incorrect table name in explain information#11780
Merged
Conversation
6f12cc9 to
39aaf2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #11780 +/- ##
===========================================
Coverage ? 81.4916%
===========================================
Files ? 434
Lines ? 93644
Branches ? 0
===========================================
Hits ? 76312
Misses ? 11872
Partials ? 5460 |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
e41a810 to
e486b88
Compare
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #11782
What is changed and how it works?
Add necessary
TableAsNamefield intoPhysicalTableScan.For case 1, add it in
constructInnerIndexScanTask.For case 2, add it in
convertToIndexScan.For case 3, this case happens because we set
TableAsNameafterbuildDataSource. In most cases it goes well, but when we need union scan, line 2348 will be triggered:The return value is
LogicalUnionScaninstead ofDataSource, soTableAsNamewill not be set in these lines ofbuildResultSetNode:So we can pass
&x.AsNameintobuildDataSource, and setTableAsNamein it.Check List
Tests
Side effects