expression: implement vectorized evaluation for builtinRepeatSig #12014
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12014 +/- ##
===============================================
- Coverage 81.3794% 81.3405% -0.039%
===============================================
Files 446 447 +1
Lines 95658 95646 -12
===============================================
- Hits 77846 77799 -47
- Misses 12287 12310 +23
- Partials 5525 5537 +12 |
XuHuaiyu
reviewed
Sep 4, 2019
XuHuaiyu
reviewed
Sep 4, 2019
zz-jason
reviewed
Sep 4, 2019
SunRunAway
reviewed
Sep 4, 2019
Contributor
|
/run-all-tests |
Member
|
to #12058 |
Contributor
|
i find a TODO at line 34 in expression/builtin_string_vec.go // TODO: introduce vectorized null-bitmap to speed it up.
if buf.IsNull(i) || buf2.IsNull(i) {
result.AppendNull()
continue
}I'm curious about how this should be done. Is it right to use function buf.MergeNulls(buf2) // before the for loop
for i := 0; i < n; i++ {
if buf.IsNull(i) { // reduce a IsNull call here
result.AppendNull()
continue
}I tried to run benchmark test but didn't find a significant performance improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinRepeatSig.What is changed and how it works?
Almost 1.5s faster than before:
Check List
Tests