expression: implement vectorized evaluation for builtinLogicXorSig#12430
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12430 +/- ##
===========================================
Coverage 79.7369% 79.7369%
===========================================
Files 462 462
Lines 102324 102324
===========================================
Hits 81590 81590
Misses 14845 14845
Partials 5889 5889 |
qw4990
reviewed
Sep 27, 2019
SunRunAway
added
the
status/can-merge
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinLogicXorSigfor #12103.What is changed and how it works?
According to benchmark, the vectorized operation is about 6 times faster than before:
Check List
Tests