expression: implement vectorized evaluation for builtinLeastRealSig#12432
Merged
Conversation
PiotrNewt
changed the title
qw4990
requested review from
SunRunAway and
qw4990
and removed request for
qw4990
Contributor
|
/run-unit-test |
zz-jason
added
status/LGT2
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12432 +/- ##
===========================================
Coverage 79.7153% 79.7153%
===========================================
Files 462 462
Lines 102447 102447
===========================================
Hits 81666 81666
Misses 14893 14893
Partials 5888 5888 |
Contributor
|
@PiotrNewt merge failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinLeastRealSig, for issue #12105What is changed and how it works?
Here is the benchmark , almost 8x faster than before:
Check List
Tests