Skip to content

session: remove unused global variable #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lonng merged 4 commits into from
Sep 29, 2019
Merged

session: remove unused global variable #12460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
498d754
session: remove unused global variable
lonng Sep 28, 2019
85da98b
Merge branch 'master' into remove-unused-code
lonng Sep 28, 2019
921473e
simplify multiQueryNoDelayRecordSet implementation
lonng Sep 28, 2019
1728e52
Merge branch 'master' into remove-unused-code
lonng Sep 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,6 @@ func (s *session) FieldList(tableName string) ([]*ast.ResultField, error) {
return fields, nil
}

// mockCommitErrorOnce use to make sure gofail mockCommitError only mock commit error once.
var mockCommitErrorOnce = true

func (s *session) doCommit(ctx context.Context) error {
if !s.txn.Valid() {
return nil
Expand Down Expand Up @@ -2046,25 +2043,15 @@ func (s *session) recordTransactionCounter(err error) {
}

type multiQueryNoDelayRecordSet struct {
sqlexec.RecordSet

affectedRows uint64
lastMessage string
status uint16
warnCount uint16
lastInsertID uint64
}

func (c *multiQueryNoDelayRecordSet) Fields() []*ast.ResultField {
panic("unsupported method")
}

func (c *multiQueryNoDelayRecordSet) Next(ctx context.Context, chk *chunk.Chunk) error {
panic("unsupported method")
}

func (c *multiQueryNoDelayRecordSet) NewChunk() *chunk.Chunk {
panic("unsupported method")
}

func (c *multiQueryNoDelayRecordSet) Close() error {
return nil
}
Expand Down