Skip to content

planner: deal with the case the blockProcessor is nil#12482

Closed
winoros wants to merge 1 commit into
pingcap:masterfrom
winoros:fix-sysbench-panic
Closed

planner: deal with the case the blockProcessor is nil#12482
winoros wants to merge 1 commit into
pingcap:masterfrom
winoros:fix-sysbench-panic

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Sep 29, 2019

What problem does this PR solve?

When the passing blockProcessor is nil. NewPlanBuilder will panic.

Check List

Tests

  • Manual test (sysbench passed)

@winoros winoros added the sig/planner SIG: Planner label Sep 29, 2019
@winoros
Copy link
Copy Markdown
Member Author

winoros commented Sep 29, 2019

/run-all-tests

@winoros
Copy link
Copy Markdown
Member Author

winoros commented Sep 29, 2019

/bench

@coocood
Copy link
Copy Markdown
Member

coocood commented Sep 29, 2019

LGTM

@winoros
Copy link
Copy Markdown
Member Author

winoros commented Sep 30, 2019

/bench

@winoros
Copy link
Copy Markdown
Member Author

winoros commented Sep 30, 2019

closed since #12486 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/planner SIG: Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants