executor: do not return first row until the frame is completed. (#12480)#12662
Merged
ngaut merged 9 commits intoOct 14, 2019
Conversation
Co-Authored-By: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>
SunRunAway
added
sig/execution
Contributor
|
Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch. |
SunRunAway
removed
needs-cherry-pick-3.0
status/LGT2
alivxxx
added
status/LGT2
ngaut
added
the
status/can-merge
Contributor
|
Your auto merge job has been accepted, waiting for 12660 |
…upstream-release-3.1
Contributor
|
/run-all-tests |
Contributor
|
@SunRunAway merge failed. |
Contributor
Author
|
/run-integration-common-test |
Contributor
|
cherry pick to release-3.1 failed |
SunRunAway
deleted the
automated-cherry-pick-of-#12480-upstream-release-3.1
branch
Contributor
|
cherry pick to release-3.0 failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cherry pick of #12480 on release-3.1.
What problem does this PR solve?
Fixes #12415.
What is changed and how it works?
In previous implementation,
windowExecreturns a chunk when a frame is fetched but not evaluated. After rewriting,windowExecreturns a chunk after a frame is finished evaluating.It makes the code simpler, and all the implementation of aggregation functions can reference the data in the frame. The bad side is it will increase the time of meeting first row.
I'll send a following PR(#12481) to revert the changes of copying data in #11678, if this is accepted by reviewers.
Check List
Tests
Code changes
Side effects
Related changes
Release note