Skip to content

Cherry pick follower read to TiDB (#11347)#13464

Merged
jackysp merged 1 commit into
pingcap:release-3.1.6from
coocood:release-3.1.6
Nov 15, 2019
Merged

Cherry pick follower read to TiDB (#11347)#13464
jackysp merged 1 commit into
pingcap:release-3.1.6from
coocood:release-3.1.6

Conversation

@coocood
Copy link
Copy Markdown
Member

@coocood coocood commented Nov 14, 2019

cherry pick #11347 to 3.1

Fix code conflicts from 4.0 to 3.1. Users can use tidb_replica_read session variable to choose reading from leader or follower. To make it consistent with existing behavior, leader will be used by default unless follower is explicitly specified otherwise.

Add a session scope variable tidb_replica_read to specify if TiDB should read data from leader or follower.

@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 14, 2019

@zz-jason @jackysp @tiancaiamao PTAL

@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 14, 2019

The original cherry-pick PR to 3.1 is #12535

@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 14, 2019

/run-all-tests

cherry pick pingcap#11347 to 3.1

Fix code conflicts from 4.0 to 3.1. Users can use tidb_replica_read session variable to choose reading from leader or follower. To make it consistent with existing behavior, leader will be used by default unless follower is explicitly specified otherwise.

Add a session scope variable tidb_replica_read to specify if TiDB should read data from leader or follower.
@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 14, 2019

/run-all-tests

@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 15, 2019

/run-all-tests tikv=release-3.1

@coocood
Copy link
Copy Markdown
Member Author

coocood commented Nov 15, 2019

/run-all-tests tikv=release-3.1 pd=release-3.1

Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2019
Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 6308931 into pingcap:release-3.1.6 Nov 15, 2019
@coocood coocood deleted the release-3.1.6 branch November 15, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants