planner/core: fix CI data race in core_test.newStoreWithBootstrap#13860
Closed
tiancaiamao wants to merge 1 commit into
Closed
planner/core: fix CI data race in core_test.newStoreWithBootstrap#13860tiancaiamao wants to merge 1 commit into
tiancaiamao wants to merge 1 commit into
Conversation
Contributor
Author
|
PTAL @zz-jason @lamxTyler |
Codecov Report
@@ Coverage Diff @@
## master #13860 +/- ##
===============================================
- Coverage 80.4239% 80.1319% -0.292%
===============================================
Files 474 474
Lines 118512 117022 -1490
===============================================
- Hits 95312 93772 -1540
- Misses 15765 15835 +70
+ Partials 7435 7415 -20 |
glorv
reviewed
Dec 3, 2019
|
|
||
| func init() { | ||
| // Init once here to avoid data race. | ||
| session.SetSchemaLease(0) |
Contributor
There was a problem hiding this comment.
master 分支里面这个已经是 atomic 操作了，所以应该没影响。 release-3.x 里面这个还是直接赋值的，所以会冲突。。
Contributor
Author
There was a problem hiding this comment.
If so, we should cherry-pick that one to release-3.0 branch.
Do you know which PR and who's the author @glorv
Contributor
Author
|
Fixed in #12910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
session.SetSchemaLease()is not thread safe.Move it away from the
newStoreWithBootstrapfunction.Make sure it's only called once in the test package planner/core.
Check List
Tests
Related changes