planner: fix push down distinct when need to inject projection#15997
Merged
Conversation
ghost
requested review from
SunRunAway
force-pushed
the
issue14623-pushdown-distinct
branch
from
12a494b to
f9cf607
Compare
SunRunAway
changed the title
SunRunAway
added
needs-cherry-pick-4.0
priority/release-blocker
Contributor
Author
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15997 +/- ##
================================================
+ Coverage 80.4506% 80.5012% +0.0506%
================================================
Files 505 505
Lines 135897 135291 -606
================================================
- Hits 109330 108911 -419
+ Misses 18062 17875 -187
Partials 8505 8505 |
Contributor
|
cherry pick to release-4.0 in PR #16000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15999
Problem Summary:
If aggregation function is avg(distinct) or sum(distinct) when
tidb_opt_distinct_agg_push_downis set to1, Planner needs to inject a projection to castcopdata from type int to type decimal. So a property offinalAggis necessary or it will panic.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects