Skip to content

session: invalid pending txn if it's a empty stmt#16325

Closed
lysu wants to merge 1 commit into
pingcap:release-3.0from
lysu:dev-fix-empty-stmt-start-wrong-txn
Closed

session: invalid pending txn if it's a empty stmt#16325
lysu wants to merge 1 commit into
pingcap:release-3.0from
lysu:dev-fix-empty-stmt-start-wrong-txn

Conversation

@lysu
Copy link
Copy Markdown
Contributor

@lysu lysu commented Apr 13, 2020

What problem does this PR solve?

Issue Number: close #15716 in 3.0

#11981 has fixed it in 4.0

Problem Summary:

execute ‘-- T1’ will be parsed as empty stmt and start a txn but without closing it after empty stmt finished

What is changed and how it works?

What's Changed:

close txn after empty stmt returned

How it Works:

close txn after empty stmt returned

Related changes

  • n/a

Check List

Tests

  • Integration test(WIP)
  • Manual test (add detailed scripts or steps below)

Side effects

  • n/a

Release note

invalid pending txn if it's a empty stmt


This change is Reviewable

@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented Apr 13, 2020

we have another chosen is cherry-pick #11981 - -

@coocood @tiancaiamao @jackysp

@lysu lysu added sig/transaction SIG:Transaction type/bugfix This PR fixes a bug. labels Apr 13, 2020
@lysu lysu closed this Apr 13, 2020
@lysu lysu deleted the dev-fix-empty-stmt-start-wrong-txn branch April 13, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/transaction SIG:Transaction type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant