Skip to content

sessionctx/variable: open batch_cop for tiflash by default (#18190)#18552

Merged
ti-srebot merged 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-8a3652814c3d
Jul 14, 2020
Merged

sessionctx/variable: open batch_cop for tiflash by default (#18190)#18552
ti-srebot merged 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-8a3652814c3d

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jul 14, 2020

cherry-pick #18190 to release-4.0


What problem does this PR solve?

Open tidb_allow_batch_cop by default and test report is https://docs.google.com/document/d/1uZqfNWwha4317sMGF92R2xovJAZCV1EWSIjhrVd0BB0/edit

Problem Summary:

batch cop is added by #16030 and its doc is pingcap/docs-cn#3265
After POC for a long time, we decide to open this feature by default.

What's Changed:

Only a default value for variable is changed.

Side effects

  • Only involve risk to tiflash.

Release note

active tidb_allow_batch_cop by default.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2020
Copy link
Copy Markdown
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 14, 2020
@SunRunAway
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit d8a785d into pingcap:release-4.0 Jul 14, 2020
@hanfei1991 hanfei1991 deleted the release-4.0-8a3652814c3d branch July 15, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/session status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants