expression: incompatibility with MySQL for ADDTIME()#21401
Closed
hidehalo wants to merge 6 commits into
Closed
Conversation
qw4990
reviewed
Dec 2, 2020
qw4990
reviewed
Dec 2, 2020
hidehalo
force-pushed
the
issue-19150
branch
from
671470c to
be29d7e
Compare
|
There is no reward for this challenge pull request, so you can request a reward from @SunRunAway. |
Contributor
Author
|
@qw4990 PTAL |
wshwsh12
reviewed
Aug 4, 2021
Comment on lines
407
to
410
Contributor
There was a problem hiding this comment.
The file is generated by go generate in expression/generator. We shouldn't edit it by manual.. Maybe we should modify the template in time_vec.go and run make gogenerate to generate the code.
Contributor
Author
Contributor
There was a problem hiding this comment.
If the reason is the same, I think we can fix it in this pr.
ti-chi-bot
added
the
size/XXL
ti-chi-bot
added
size/M
hidehalo
commented
Aug 12, 2021
ti-chi-bot
added
the
release-note
ti-chi-bot
removed
the
do-not-merge/release-note-label-needed
Contributor
|
Test case fails |
hidehalo
commented
Aug 13, 2021
| if isNull || err != nil { | ||
| return "", isNull, err | ||
| } | ||
| if !isDuration(arg1Str) { |
Contributor
Author
There was a problem hiding this comment.
Test case fails
[2021-08-12T09:34:14.503Z] FAIL: builtin_time_test.go:903: testEvaluatorSuite.TestAddTimeSig [2021-08-12T09:34:14.503Z] [2021-08-12T09:34:14.503Z] builtin_time_test.go:1012: [2021-08-12T09:34:14.503Z] c.Assert(len(warnings), Equals, i+1+beforeWarnCnt) [2021-08-12T09:34:14.503Z] ... obtained int = 8 [2021-08-12T09:34:14.503Z] ... expected int = 9 [2021-08-12T09:34:14.503Z]
Here is the reason, if arg1Str is not a MySQL Time, it just return without error.
hidehalo
commented
Aug 13, 2021
| return "", true, nil | ||
| } | ||
| sc := b.ctx.GetSessionVars().StmtCtx | ||
| arg1, err = types.ParseDuration(sc, arg1Str, getFsp4TimeAddSub(arg1Str)) |
Contributor
Author
Contributor
There was a problem hiding this comment.
I don't think so. MySQL also doesn't throw a error/warning.
Contributor
Author
There was a problem hiding this comment.
It's make sense. Should we remove those two test cases(below)? Or we should throw a error/warning inside func (b *builtinAddStringAndStringSig) evalString(row chunk.Row)?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19150
What is changed and how it works?
What's Changed:
builtinAddStringStringSigeval/vecEval return null whenarg1isn'tDurationtype (eg:ADDTIME('2020-05-13 14:01:24', '2020-04-29 05:11:19'))How it Works:
make
builtinAddStringStringSigreturn null whenarg1isn'tDurationtype (eg:ADDTIME('2020-05-13 14:01:24', '2020-04-29 05:11:19'))Related changes
Tests
Side effects
Release note