Skip to content

store/tikv: resolve metrics dependency#22542

Merged
ti-srebot merged 6 commits into
pingcap:masterfrom
disksing:metrics
Jan 28, 2021
Merged

store/tikv: resolve metrics dependency#22542
ti-srebot merged 6 commits into
pingcap:masterfrom
disksing:metrics

Conversation

@disksing
Copy link
Copy Markdown
Contributor

@disksing disksing commented Jan 26, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Resolve metrics related dependencies.
Part of #22513

What is changed and how it works?

What's Changed:

  • Move metrics variables to store/tikv/metrics
  • Add functions to allow reset namespace and subsystem
  • Update usage

Note: not all metrics are migrated.

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
AndreMouche
AndreMouche previously approved these changes Jan 27, 2021
Copy link
Copy Markdown
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
andylokandy
andylokandy previously approved these changes Jan 28, 2021
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2021
ti-srebot
ti-srebot previously approved these changes Jan 28, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 28, 2021
@disksing
Copy link
Copy Markdown
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 22566

@disksing disksing dismissed stale reviews from ti-srebot and andylokandy via f31174d January 28, 2021 10:16
@disksing
Copy link
Copy Markdown
Contributor Author

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@disksing merge failed.

@disksing
Copy link
Copy Markdown
Contributor Author

/merge

2 similar comments
@disksing
Copy link
Copy Markdown
Contributor Author

/merge

@disksing
Copy link
Copy Markdown
Contributor Author

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@disksing merge failed.

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e8395b7 into pingcap:master Jan 28, 2021
@disksing disksing deleted the metrics branch January 28, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/store status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants