Skip to content

ddl: rename const to common, separate its test [1/6]#24004

Merged
ti-chi-bot merged 8 commits into
pingcap:masterfrom
xhebox:master_1
Apr 15, 2021
Merged

ddl: rename const to common, separate its test [1/6]#24004
ti-chi-bot merged 8 commits into
pingcap:masterfrom
xhebox:master_1

Conversation

@xhebox
Copy link
Copy Markdown
Contributor

@xhebox xhebox commented Apr 14, 2021

What problem does this PR solve?

Problem Summary: Separate from #22415, 1/6 patch from the large PR.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from a team April 14, 2021 06:14
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2021
@wjhuang2016
Copy link
Copy Markdown
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
@morgo
Copy link
Copy Markdown
Contributor

morgo commented Apr 14, 2021

/LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2021
@xhebox
Copy link
Copy Markdown
Contributor Author

xhebox commented Apr 15, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 35dea6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@xhebox: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d4164ff into pingcap:master Apr 15, 2021
@xhebox xhebox deleted the master_1 branch April 20, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants