ddl: speedup test case TestModifyColumnTime by jianzhiyao · Pull Request #24469 · pingcap/tidb

jianzhiyao · 2021-05-07T12:20:53Z

What problem does this PR solve?

Issue Number: #24459

Problem Summary:

What is changed and how it works?

split testDBSuite1.TestModifyColumnTime into many parts

build & test time

Comparing with pr: #24460, test time is reduced about 50s

pr	check_dev	check_dev_2
#24460	3m 7s(link)	6m 10s(link)
#24469	2m 13s(link)	5m 15s(link)

Check List

Tests

No code

Side effects

Performance regression
- Consumes more CPU
- Consumes more MEM

Release note

ddl: speedup test case TestModifyColumnTime

zimulala

Could you add a description of how long the tests were executed before and after this PR?

zimulala · 2021-05-08T02:04:35Z

I don't think it's necessary to drive so many goroutines.

I think so :-)

xhebox · 2021-05-10T04:13:51Z

@jianzhiyao Could you use the same trick as in #24487 ? Testcases in this test are actually standalone. I think splitted tests are better than shooting goroutines. Of course, only if it is indeed faster.

AilinKid · 2021-05-10T06:35:36Z

/dissmiss

xhebox

Rest LGTM

xhebox · 2021-05-10T06:36:14Z

+	}()

 	for _, t := range tests {
 		tk.MustExec("drop table if exists t_mc")


Tablename duplicated for cases, plz fix.

According to the result of check_dev and check_dev_2 , seems tablename can be the same in different test case.

Testcases could be paralleled, under which case it will fail... But I'll give you LGTM anyway.

jianzhiyao · 2021-05-10T06:38:40Z

/dissmiss

PTAL again after test passed

xhebox · 2021-05-10T07:12:22Z

/lgtm

ti-chi-bot · 2021-05-10T07:12:25Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

xhebox · 2021-05-10T07:12:29Z

/merge

ti-chi-bot · 2021-05-10T07:12:32Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 1b1975c

ti-chi-bot · 2021-05-10T20:09:45Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-11T01:19:45Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

jianzhiyao · 2021-05-11T02:04:25Z

/run-common-test

jianzhiyao · 2021-05-11T02:11:21Z

/run-integration-common-test

jianzhiyao · 2021-05-11T02:16:04Z

/run-common-test

jianzhiyao · 2021-05-11T02:25:20Z

/run-unit-test

0xPoe · 2021-05-11T02:39:09Z

/run-all-tests

0xPoe · 2021-05-11T02:48:46Z

/run-integration-ddl-test

jianzhiyao · 2021-05-11T03:57:44Z

/run-tics-test
/run-sqllogic-test-1
/run-sqllogic-test-2
/run-integration-ddl-test

ti-chi-bot · 2021-05-11T04:47:49Z

@jianzhiyao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021

github-actions Bot added the sig/sql-infra SIG: SQL Infra label May 7, 2021

jianzhiyao force-pushed the frt/speedup_test_modify_time branch from f9fa804 to e20c345 Compare May 7, 2021 12:41

zimulala reviewed May 8, 2021

View reviewed changes

zimulala added the component/test label May 8, 2021

jianzhiyao force-pushed the frt/speedup_test_modify_time branch 4 times, most recently from d7f654b to 8b9c2fe Compare May 8, 2021 04:05

jianzhiyao requested a review from zimulala May 8, 2021 10:00

ddl: speedup test case TestModifyColumnTime

a5e7098

jianzhiyao force-pushed the frt/speedup_test_modify_time branch from 8b9c2fe to a5e7098 Compare May 10, 2021 06:21

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2021

Merge branch 'master' into frt/speedup_test_modify_time

1b1975c

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021

pingcap deleted a comment from ti-chi-bot May 10, 2021

AilinKid removed the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021

xhebox reviewed May 10, 2021

View reviewed changes

jianzhiyao requested a review from xhebox May 10, 2021 07:06

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021

jianzhiyao and others added 2 commits May 10, 2021 16:41

Merge branch 'master' into frt/speedup_test_modify_time

d195200

Merge branch 'master' into frt/speedup_test_modify_time

a5014af

Merge branch 'master' into frt/speedup_test_modify_time

45b4ad4

Merge branch 'master' into frt/speedup_test_modify_time

054e226

Merge branch 'master' into frt/speedup_test_modify_time

0e4dae5

ti-chi-bot added 2 commits May 11, 2021 12:40

Merge branch 'master' into frt/speedup_test_modify_time

5baa5c4

Merge branch 'master' into frt/speedup_test_modify_time

3ea59d2

ti-chi-bot merged commit 24e9c13 into pingcap:master May 11, 2021

Conversation

jianzhiyao commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

build & test time

Check List

Release note

Uh oh!

zimulala left a comment

Choose a reason for hiding this comment

Uh oh!

zimulala May 8, 2021

Choose a reason for hiding this comment

Uh oh!

jianzhiyao May 8, 2021

Choose a reason for hiding this comment

Uh oh!

xhebox commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AilinKid commented May 10, 2021

Uh oh!

xhebox left a comment

Choose a reason for hiding this comment

Uh oh!

xhebox May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianzhiyao May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xhebox May 10, 2021

Choose a reason for hiding this comment

Uh oh!

jianzhiyao commented May 10, 2021

Uh oh!

xhebox commented May 10, 2021

Uh oh!

ti-chi-bot commented May 10, 2021

Uh oh!

xhebox commented May 10, 2021

Uh oh!

ti-chi-bot commented May 10, 2021

Uh oh!

ti-chi-bot commented May 10, 2021

Uh oh!

ti-chi-bot commented May 11, 2021

Uh oh!

jianzhiyao commented May 11, 2021

Uh oh!

jianzhiyao commented May 11, 2021

Uh oh!

jianzhiyao commented May 11, 2021

Uh oh!

jianzhiyao commented May 11, 2021

Uh oh!

0xPoe commented May 11, 2021

Uh oh!

0xPoe commented May 11, 2021

Uh oh!

jianzhiyao commented May 11, 2021

Uh oh!

ti-chi-bot commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jianzhiyao commented May 7, 2021 •

edited

Loading

xhebox commented May 10, 2021 •

edited

Loading

xhebox May 10, 2021 •

edited

Loading

jianzhiyao May 10, 2021 •

edited

Loading