planner: Add the tableInfo parameter for the GetNetworkFactor in the TableReaderImpl.CalcCost#25134
Closed
mmyj wants to merge 7 commits into
Closed
planner: Add the tableInfo parameter for the GetNetworkFactor in the TableReaderImpl.CalcCost#25134mmyj wants to merge 7 commits into
tableInfo parameter for the GetNetworkFactor in the TableReaderImpl.CalcCost#25134mmyj wants to merge 7 commits into
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
djshow832
reviewed
Jun 4, 2021
| tableInfo *model.TableInfo | ||
| ts = reader.GetTableScan() | ||
| ) | ||
| if ts != nil { |
Contributor
There was a problem hiding this comment.
So when will it be nil? That could make cost estimation inaccurate again.
This reverts commit 04b9f04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
In the PR #25046,
TableReaderImpldon't havetableInfoproperty, so I had left a todo comment, usingnilas parameter to get network factor. Now I found thatGetTableScanfunction can get thetableInfoofTableReaderImpland resolve above problem.What is changed and how it works?
How it Works:
Using
GetTableScanto get thetableInfoproperty ofTableReaderImplRelated changes
Check List
Tests
Side effects
Release note
tableInfoparameter for theGetNetworkFactorin theTableReaderImpl.CalcCost