Skip to content

executor: fix a bug in filterTemporaryTableKeys() function#25521

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
tiancaiamao:filter-keys
Jun 17, 2021
Merged

executor: fix a bug in filterTemporaryTableKeys() function#25521
ti-chi-bot merged 2 commits into
pingcap:masterfrom
tiancaiamao:filter-keys

Conversation

@tiancaiamao
Copy link
Copy Markdown
Contributor

@tiancaiamao tiancaiamao commented Jun 17, 2021

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

What's Changed:

A silly mistake in https://github.com/pingcap/tidb/pull/24737/files#diff-4c9a4c1e9a402d07a0a78f4db9f766d23f1ff57ceda1e75c4e83b579488ad301R1037

Should use [:0], but use [:]

How it Works:

Fix bug

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

  • No release note

@tiancaiamao tiancaiamao requested a review from a team as a code owner June 17, 2021 07:53
@tiancaiamao tiancaiamao requested review from lzmhhh123 and removed request for a team June 17, 2021 07:53
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@lcwangchao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@github-actions github-actions Bot added the sig/execution SIG execution label Jun 17, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 056c7d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@ti-chi-bot ti-chi-bot merged commit ed686d1 into pingcap:master Jun 17, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.1 in PR #25522

@bb7133 bb7133 changed the title executor: fix a stupid mistake in filterTemporaryTableKeys() function executor: fix a bug in filterTemporaryTableKeys() function Jun 18, 2021
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants