planner: Log warnings when agg function can not be pushdown in explain statement by windtalker · Pull Request #25553 · pingcap/tidb

windtalker · 2021-06-18T04:29:11Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
After #22713, if an expression can not be pushdown to storage layer, it will log a warning if current sql is an explain statement, however, for aggregation function agg(expr) if it can not be pushdown to storage layer becuase expr is not supported, no warning is logged because current implementation call AggFuncToPBExpr directly to check if the agg function can be pushed to storage layer.

What is changed and how it works?

Proposal: xxx

What's Changed:

Refine CheckAggCanPushCop and log warnings when agg function can not be pushdown in explain statement.
How it Works:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Side effects

Performance regression
- Consumes more CPU
- Consumes more MEM
Breaking backward compatibility

Release note

Log warnings when agg function can not be pushdown in explain statement

…_pushdown_warnings

sre-bot · 2021-06-18T04:29:42Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

*: what's changed

…_pushdown_warnings

windtalker · 2021-06-21T09:08:24Z

/label needs-cherry-pick-5.0

windtalker · 2021-06-21T09:08:54Z

/label needs-cherry-pick-5.1

fzhedu · 2021-06-22T07:00:36Z

/run-all-tests

fzhedu · 2021-06-22T09:18:49Z

+	tk.MustExec("explain select max(date_add(value, interval 1 day)) from show_warnings_expr_pushdown group by a")
+	c.Assert(tk.Se.GetSessionVars().StmtCtx.WarningCount(), Equals, uint16(2))


what if the unsupported function occur in group by?

and distinct?

Add tests about groupBy and distinct.

…_pushdown_warnings

fzhedu

/LGTM

ti-chi-bot · 2021-06-24T07:14:14Z

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-06-24T07:14:15Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

fzhedu
hanfei1991

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

fzhedu · 2021-06-24T07:14:23Z

/merge

ti-chi-bot · 2021-06-24T07:14:25Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 23e3fcc

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-06-24T07:23:23Z

cherry pick to release-5.0 in PR #25736

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-06-24T07:26:29Z

cherry pick to release-5.1 in PR #25737

…n statement (pingcap#25553)

…n statement (#25553) (#25736)

…n statement (pingcap#25553)

…n statement (#25553) (#25737)

windtalker added 4 commits May 19, 2021 10:11

add warnings when agg is not able to push down to storage layer

90dade1

Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…

f3dae65

…_pushdown_warnings

merge master

bc5654e

refine

4ae25e9

windtalker requested a review from a team as a code owner June 18, 2021 04:29

windtalker requested review from time-and-fate and removed request for a team June 18, 2021 04:29

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 18, 2021

windtalker changed the title ~~Log warnings when agg function can not be pushdown in explain statement~~ planner: Log warnings when agg function can not be pushdown in explain statement Jun 18, 2021

windtalker added 4 commits June 18, 2021 12:32

Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…

6f2b74c

…_pushdown_warnings

Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…

9fad8c7

…_pushdown_warnings

Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…

b024e7f

…_pushdown_warnings

add tests

b350073

windtalker requested a review from a team as a code owner June 21, 2021 09:06

windtalker requested review from XuHuaiyu and removed request for a team June 21, 2021 09:06

ti-chi-bot added the needs-cherry-pick-release-5.0 label Jun 21, 2021

ti-chi-bot added the needs-cherry-pick-release-5.1 label Jun 21, 2021

hanfei1991 approved these changes Jun 21, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021

github-actions Bot added the sig/execution SIG execution label Jun 21, 2021

fzhedu reviewed Jun 22, 2021

View reviewed changes

windtalker added 4 commits June 22, 2021 17:37

Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…

20aa519

…_pushdown_warnings

add more tests

a0387d6

add more tests

1bce974

update tests

0300490

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2021

fix ci

23e3fcc

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2021

fzhedu approved these changes Jun 24, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021

ti-chi-bot merged commit 27489d4 into pingcap:master Jun 24, 2021

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 24, 2021

cherry pick pingcap#25553 to release-5.0

a162e06

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jun 24, 2021

planner: Log warnings when agg function can not be pushdown in explain statement (#25553) #25736

Merged

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 24, 2021

cherry pick pingcap#25553 to release-5.1

d196c2e

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jun 24, 2021

planner: Log warnings when agg function can not be pushdown in explain statement (#25553) #25737

Merged

tisonkun mentioned this pull request Jun 24, 2021

tidb_ghpr_integration_common_test failed on Integration MySQL Test #25738

Closed

jiajunhuang pushed a commit to jiajunhuang/tidb that referenced this pull request Jun 28, 2021

planner: Log warnings when agg function can not be pushdown in explai…

e1d4760

…n statement (pingcap#25553)

ti-chi-bot pushed a commit that referenced this pull request Jul 20, 2021

planner: Log warnings when agg function can not be pushdown in explai…

0192259

…n statement (#25553) (#25736)

LittleFall pushed a commit to LittleFall/tidb that referenced this pull request Jul 20, 2021

planner: Log warnings when agg function can not be pushdown in explai…

13f9ba8

…n statement (pingcap#25553)

LittleFall mentioned this pull request Jul 20, 2021

DNM: planner: cherry-pick enforce-mpp to v5.0 #26378

Closed

10 tasks

LittleFall pushed a commit to LittleFall/tidb that referenced this pull request Jul 20, 2021

planner: Log warnings when agg function can not be pushdown in explai…

d3d2f52

…n statement (pingcap#25553)

LittleFall mentioned this pull request Jul 20, 2021

planner: cherry-pick enforce-mpp to v5.0 #26382

Merged

10 tasks

ti-chi-bot pushed a commit that referenced this pull request Jul 22, 2021

planner: Log warnings when agg function can not be pushdown in explai…

28ebe81

…n statement (#25553) (#25737)

windtalker deleted the agg_not_pushdown_warnings branch November 16, 2021 01:24

		tk.MustExec("explain select max(date_add(value, interval 1 day)) from show_warnings_expr_pushdown group by a")
		c.Assert(tk.Se.GetSessionVars().StmtCtx.WarningCount(), Equals, uint16(2))

Conversation

windtalker commented Jun 18, 2021

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

Uh oh!

sre-bot commented Jun 18, 2021

Uh oh!

windtalker commented Jun 21, 2021

Uh oh!

windtalker commented Jun 21, 2021

Uh oh!

fzhedu commented Jun 22, 2021

Uh oh!

fzhedu Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

fzhedu Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

windtalker Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

fzhedu left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Jun 24, 2021

Uh oh!

ti-chi-bot commented Jun 24, 2021

Uh oh!

fzhedu commented Jun 24, 2021

Uh oh!

ti-chi-bot commented Jun 24, 2021

Uh oh!

ti-srebot commented Jun 24, 2021

Uh oh!

ti-srebot commented Jun 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants