Skip to content

test: make test TestIssue25506 stable#25617

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
crazycs520:fix-TestIssue25506
Jun 21, 2021
Merged

test: make test TestIssue25506 stable#25617
ti-chi-bot merged 1 commit into
pingcap:masterfrom
crazycs520:fix-TestIssue25506

Conversation

@crazycs520
Copy link
Copy Markdown
Contributor

Signed-off-by: crazycs crazycs520@gmail.com

What problem does this PR solve?

As the title said.

[2021-06-21T13:13:11.256Z] ----------------------------------------------------------------------
[2021-06-21T13:13:11.256Z] FAIL: executor_test.go:8659: testSuite.TestIssue25506
[2021-06-21T13:13:11.256Z] 
[2021-06-21T13:13:11.256Z] executor_test.go:8668:
[2021-06-21T13:13:11.256Z]     tk.MustQuery("(select col_15 from tbl_23) union all (select col_15 from tbl_3 for update)").Check(testkit.Rows("\x00\x00\x0F", "\x00\xFF\xFF", "\x00\x00\xFF"))
[2021-06-21T13:13:11.256Z] /home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:63:
[2021-06-21T13:13:11.256Z]     res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
[2021-06-21T13:13:11.256Z] ... obtained string = "" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\xff\xff]\n" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\x00\xff]\n" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\x00\x0f]\n"
[2021-06-21T13:13:11.256Z] ... expected string = "" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\x00\x0f]\n" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\xff\xff]\n" +
[2021-06-21T13:13:11.256Z] ...     "[\x00\x00\xff]\n"
[2021-06-21T13:13:11.256Z] ... sql:(select col_15 from tbl_23) union all (select col_15 from tbl_3 for update), args:[]

Check List

Tests

  • No code

Side effects

  • N/A

Release note

  • No release note.

Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner June 21, 2021 13:28
@crazycs520 crazycs520 requested review from wshwsh12 and removed request for a team June 21, 2021 13:28
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2021
@crazycs520
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@crazycs520
Copy link
Copy Markdown
Contributor Author

@zhaoxugang @wshwsh12 @mmyj PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@lysu
Copy link
Copy Markdown
Contributor

lysu commented Jun 21, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b0edb32

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 3a1f65a into pingcap:master Jun 21, 2021
@crazycs520 crazycs520 deleted the fix-TestIssue25506 branch June 21, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants