Skip to content

ddl: DROP GLOBAL TEMPORARY TABLE should fail on normal tables#25639

Merged
ti-chi-bot merged 13 commits into
pingcap:masterfrom
Howie59:issue-25595
Jun 24, 2021
Merged

ddl: DROP GLOBAL TEMPORARY TABLE should fail on normal tables#25639
ti-chi-bot merged 13 commits into
pingcap:masterfrom
Howie59:issue-25595

Conversation

@Howie59
Copy link
Copy Markdown
Contributor

@Howie59 Howie59 commented Jun 22, 2021

Signed-off-by: lihaowei haoweili35@gmail.com

What problem does this PR solve?

Issue Number: close #25595

What is changed and how it works?

Proposal: temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59
fix issue#25595
7a5e5dc 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@Howie59 Howie59 requested a review from a team as a code owner June 22, 2021 01:37
@Howie59 Howie59 requested review from winoros and removed request for a team June 22, 2021 01:37
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
bb7133
bb7133 reviewed Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
Comment thread planner/core/preprocess.go Outdated
p.checkDropTableNames(stmt.Tables)
enableNoopFuncs := p.ctx.GetSessionVars().EnableNoopFuncs
if stmt.TemporaryKeyword == ast.TemporaryLocal && !enableNoopFuncs {
if stmt.TemporaryKeyword != ast.TemporaryNone && !enableNoopFuncs {
Copy link
Copy Markdown
Contributor

@djshow832 djshow832 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, dropping global temporary tables is fine for DROP GLOBAL TEMPORARY TABLE ....
E.g.

create global temporary table temp(id int) on commit delete rows;
drop global temporary table temp;   # fine

@Howie59
add tests
2e713b2 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
Howie59 added 2 commits June 22, 2021 15:13
@Howie59
Merge branch 'master' into issue-25595
95a3140
@Howie59
format code
a48c6b3 
Signed-off-by: lihaowei <haoweili35@gmail.com>
djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
Comment thread planner/core/preprocess.go
Comment thread planner/core/preprocess.go Outdated
Howie59 added 2 commits June 22, 2021 20:12
@Howie59
fix err
af4db89 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@Howie59
Merge branch 'master' of https://github.bokerqi.top.cnpmjs.org/pingcap/tidb i…
dbbab38 
…nto issue-25595
djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
Comment thread planner/core/preprocess.go Outdated
Comment thread planner/core/preprocess.go Outdated
Comment thread planner/core/preprocess.go Outdated
djshow832
djshow832 reviewed Jun 24, 2021
View reviewed changes
Comment thread planner/core/preprocess.go
@djshow832 djshow832 requested review from tiancaiamao and removed request for winoros June 24, 2021 06:32
@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Jun 24, 2021
@Howie59
Copy link
Copy Markdown
Contributor Author

Howie59 commented Jun 24, 2021

/run-check_dev_2

djshow832
djshow832 reviewed Jun 24, 2021
View reviewed changes
Comment thread planner/core/preprocess_test.go Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Jun 24, 2021

/run-check_dev_2

@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Jun 24, 2021

It seems some tests panic and the CI never finish ... I'm not sure is it related to this change or our master branch is unstable

@djshow832
Copy link
Copy Markdown
Contributor

djshow832 commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a59fa6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Jun 24, 2021

ref #25724

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2b445a1 into pingcap:master Jun 24, 2021
@Howie59 Howie59 deleted the issue-25595 branch June 24, 2021 11:04
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Jun 25, 2021
@Howie59 @tiancaiamao
ddl: DROP GLOBAL TEMPORARY TABLE should fail on normal tables (pingca…
517d6ae 
…p#25639)
jiajunhuang pushed a commit to jiajunhuang/tidb that referenced this pull request Jun 28, 2021
@Howie59 @jiajunhuang
ddl: DROP GLOBAL TEMPORARY TABLE should fail on normal tables (pingca…
97ed66b 
…p#25639)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DROP GLOBAL TEMPORARY TABLE should fail on normal tables

5 participants

@Howie59 @ti-chi-bot @tiancaiamao @djshow832 @bb7133