Skip to content

planner: enforce projection push down (#25450)#25740

Closed
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9ca449b8bd3a
Closed

planner: enforce projection push down (#25450)#25740
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9ca449b8bd3a

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jun 24, 2021

cherry-pick #25450 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25740

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25740:release-5.0-9ca449b8bd3a

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: if enforced MPP, we push down projection to tiflash.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot requested review from a team as code owners June 24, 2021 07:41
@ti-srebot ti-srebot requested review from qw4990 and removed request for a team June 24, 2021 07:41
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 24, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 24, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@fzhedu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2021
@qw4990 qw4990 removed their request for review June 25, 2021 03:05
Comment thread executor/tiflash_test.go
tk.MustQuery("select avg(a), a from t group by a").Check(testkit.Rows("9223372036854775807.0000 9223372036854775807"))
}

<<<<<<< HEAD
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the conflicts

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@fzhedu fzhedu closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants