Skip to content

executor: Modify temporary table behavior for history read#25747

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
lcwangchao:temp_table_history_read
Jun 24, 2021
Merged

executor: Modify temporary table behavior for history read#25747
ti-chi-bot merged 6 commits into
pingcap:masterfrom
lcwangchao:temp_table_history_read

Conversation

@lcwangchao
Copy link
Copy Markdown
Collaborator

@lcwangchao lcwangchao commented Jun 24, 2021

What problem does this PR solve?

Problem Summary:

Some tools like dumpling or mydumper will read all tables to dump data. To make a compatible behavior with these tools, a history read to temp table should not return error

What is changed and how it works?

do not return error when history read temporary table

Related changes

  • N/A

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • No release note

@lcwangchao lcwangchao requested a review from a team as a code owner June 24, 2021 11:47
@lcwangchao lcwangchao requested review from wshwsh12 and removed request for a team June 24, 2021 11:47
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2021
@lcwangchao lcwangchao requested review from djshow832 and tiancaiamao and removed request for wshwsh12 June 24, 2021 11:47
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Jun 24, 2021

ref #25724

djshow832
djshow832 reviewed Jun 24, 2021
View reviewed changes
Comment thread executor/executor_test.go Outdated
@github-actions github-actions Bot added the sig/execution SIG execution label Jun 24, 2021
@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Jun 24, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@lcwangchao
Copy link
Copy Markdown
Collaborator Author

lcwangchao commented Jun 24, 2021

/run-check_dev_2

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Jun 24, 2021

We will need to update the document later about the behaviour

@djshow832
Copy link
Copy Markdown
Contributor

djshow832 commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a59c645

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@djshow832
Copy link
Copy Markdown
Contributor

djshow832 commented Jun 24, 2021

We will need to update the document later about the behaviour

@tiancaiamao Which document? The RFC is fine, it's normal that it's out of date. The user doc is not filed.

@ti-chi-bot ti-chi-bot merged commit 362ede5 into pingcap:master Jun 24, 2021
@lcwangchao lcwangchao deleted the temp_table_history_read branch June 24, 2021 14:05
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Jun 25, 2021
@lcwangchao @tiancaiamao
executor: Modify temporary table behavior for history read (pingcap#2…
6c08fdb 
…5747)
jiajunhuang pushed a commit to jiajunhuang/tidb that referenced this pull request Jun 28, 2021
@lcwangchao @jiajunhuang
executor: Modify temporary table behavior for history read (pingcap#2…
3ada1b6 
…5747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

No one assigned

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lcwangchao @tiancaiamao @ti-chi-bot @djshow832