executor: tablesample for temporary table should always return empty#25752
Merged
Conversation
ti-chi-bot
added
the
size/M
lcwangchao
requested review from
djshow832 and
tiancaiamao
and removed request for
qw4990
djshow832
approved these changes
Jun 24, 2021
Contributor
|
ref #25724 |
tiancaiamao
approved these changes
Jun 24, 2021
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 7b0814c |
ti-chi-bot
added
the
status/can-merge
tiancaiamao
pushed a commit
to tiancaiamao/tidb
that referenced
this pull request
Jun 25, 2021
jiajunhuang
pushed a commit
to jiajunhuang/tidb
that referenced
this pull request
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
tablesample for temporary table should not return error for compatibility of tools like dumpling
What is changed and how it works?
always return empty when tablesampling a temporary table
Related changes
Check List
Tests
Side effects
Release note