Skip to content

planner, executor: add stale read compatibility for temporary table (#25206)#25786

Closed
ti-srebot wants to merge 2 commits into
pingcap:release-5.1from
ti-srebot:release-5.1-811253785c0e
Closed

planner, executor: add stale read compatibility for temporary table (#25206)#25786
ti-srebot wants to merge 2 commits into
pingcap:release-5.1from
ti-srebot:release-5.1-811253785c0e

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jun 28, 2021

cherry-pick #25206 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25786

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25786:release-5.1-811253785c0e

What problem does this PR solve?

Temporary table should not perform stale read

What is changed and how it works?

Add member variable ExplicitStaleness to builder to mark if this query statement should use stale read explicitly. If the txn is staleness or query is marked staleness, temporary table read should be fail.

Related changes

N/A

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners June 28, 2021 02:54
@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team June 28, 2021 02:54
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.1-cherry-pick labels Jun 28, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@lcwangchao please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

@lcwangchao Please resolve conflicts, rest looks good to me

@lzmhhh123 lzmhhh123 removed their request for review July 5, 2021 02:09
@lcwangchao
Copy link
Copy Markdown
Collaborator

Already merged in another pr: #25724

@lcwangchao lcwangchao closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.1-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants