Skip to content

planner: Make temporary table calculate right cost for cascades optimizer #25958

Merged
ti-chi-bot merged 4 commits into
pingcap:masterfrom
lcwangchao:tmp_table_cost_cascade
Jul 7, 2021
Merged

planner: Make temporary table calculate right cost for cascades optimizer #25958
ti-chi-bot merged 4 commits into
pingcap:masterfrom
lcwangchao:tmp_table_cost_cascade

Conversation

@lcwangchao
Copy link
Copy Markdown
Collaborator

planner: Make temporary table calculate right cost for cascade optimizer

What problem does this PR solve?

Issue Number: close #25957

What is changed and how it works?

Add tblInfo for IndexReaderImpl and TableReaderImpl to make right CalCost result

Related changes

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2021
@lcwangchao lcwangchao changed the title planner: Make temporary table calculate right cost for cascade optimizer planner: Make temporary table calculate right cost for cascades optimizer Jul 5, 2021
@lcwangchao
Copy link
Copy Markdown
Collaborator Author

/run-check_dev_2

@lcwangchao lcwangchao closed this Jul 6, 2021
@lcwangchao lcwangchao reopened this Jul 6, 2021
@lcwangchao lcwangchao mentioned this pull request Jul 6, 2021
89 tasks
Copy link
Copy Markdown
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some test cases?

Comment thread planner/implementation/datasource.go Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 142a7c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from ti-chi-bot Jul 7, 2021
@ti-chi-bot ti-chi-bot merged commit 297a90d into pingcap:master Jul 7, 2021
@lcwangchao lcwangchao deleted the tmp_table_cost_cascade branch July 7, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete getting network factor for temporary table using cascade optimizer

4 participants