session: Fix txn.onStmtEnd is not called when some special error occurs in ExecutePreparedStmt (#26056)

[ti-srebot]

cherry-pick #26056 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26080

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26080:release-5.1-7670912948f0

---

What problem does this PR solve?

Problem Summary:

In this part of code, previously it calls onStmtStart, calculates the result, calls onStmtEnd, and return the result. However later some modification to this code adds some more return statements between the onStmtStart and onStmtEnd calls, which makes the onStmtEnd not called in some rare cases. This PR fixes it by calling onStmtEnd in defer statement.

What is changed and how it works?

What's Changed: Call the onStmtEnd in defer stmt.

Related changes

• Need to cherry-pick to the release branch
  • release-5.1

Check List

Tests

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

• No release note.

[ti-srebot]

/run-all-tests

[ti-srebot]

@MyonKeminta you're already a collaborator in bot's repo.

[cfzjywxk]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cfzjywxk
• longfangsong

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[zhouqiang-cl]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 3c1eaed

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.