Skip to content

ddl: Create temporary table like tbl_xx#26113

Merged
ti-chi-bot merged 32 commits into
pingcap:masterfrom
zhaoxugang:for_issue_25890
Aug 12, 2021
Merged

ddl: Create temporary table like tbl_xx#26113
ti-chi-bot merged 32 commits into
pingcap:masterfrom
zhaoxugang:for_issue_25890

Conversation

@zhaoxugang
Copy link
Copy Markdown
Contributor

@zhaoxugang zhaoxugang commented Jul 11, 2021

What problem does this PR solve?

Issue Number: close #25890

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Create temporary table like tbl_xx

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2021
@github-actions github-actions Bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 11, 2021
@zhaoxugang
Copy link
Copy Markdown
Contributor Author

zhaoxugang commented Jul 11, 2021

/rebuild

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2021
lcwangchao
lcwangchao reviewed Aug 3, 2021
View reviewed changes
Comment thread ddl/serial_test.go
djshow832
djshow832 reviewed Aug 3, 2021
View reviewed changes
Comment thread ddl/ddl_api.go
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2021
@zhaoxugang
Copy link
Copy Markdown
Contributor Author

zhaoxugang commented Aug 8, 2021

/rebuild

@lcwangchao lcwangchao self-requested a review August 12, 2021 06:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@djshow832
Copy link
Copy Markdown
Contributor

djshow832 commented Aug 12, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f3aae12

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@lcwangchao
Copy link
Copy Markdown
Collaborator

lcwangchao commented Aug 12, 2021

/run-unit-test

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 12, 2021

@zhaoxugang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from ti-chi-bot Aug 12, 2021
@lcwangchao
Copy link
Copy Markdown
Collaborator

lcwangchao commented Aug 12, 2021

/rebuild

@ti-chi-bot ti-chi-bot merged commit ce60af5 into pingcap:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

No one assigned

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ddl: Create temporary table like tbl_xx

4 participants

@zhaoxugang @ti-chi-bot @djshow832 @lcwangchao