Skip to content

*: fix bug that write on temporary table send request to TiKV (#25535)#26516

Closed
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9f18723e6af2
Closed

*: fix bug that write on temporary table send request to TiKV (#25535)#26516
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9f18723e6af2

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jul 23, 2021

cherry-pick #25535 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26516

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26516:release-5.0-9f18723e6af2

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Write on a temporary table should not send request to TiKV

What is changed and how it works?

What's Changed:

Fix a bug introduced by #24196
I thought remove the temporary KV entries from the transaction buffer could avoid sending request to TiKV.
But I'm wrong. The membuffer.Delete() API causes sending delete keys to TiKV ...

How it Works:

Now I use the transaction SetKVFilter() API to ignore the temporary table KV entries.
See https://github.com/tikv/client-go/blob/b9e4cb538f3028c8a3cdaa6d04d6b47e2dcb322c/tikv/2pc.go#L357

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot requested a review from a team as a code owner July 23, 2021 14:22
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team July 23, 2021 14:22
@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/executor sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Jul 23, 2021
@ti-srebot ti-srebot requested review from coocood and djshow832 July 23, 2021 14:22
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jul 23, 2021
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 23, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

Should be cherry pick to 5.1, not to 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/executor do-not-merge/cherry-pick-not-approved sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants