*: fix bug that write on temporary table send request to TiKV (#25535)#26519
*: fix bug that write on temporary table send request to TiKV (#25535)#26519ti-srebot wants to merge 1 commit into
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiancaiamao you're already a collaborator in bot's repo. |
|
It's already there. |
cherry-pick #25535 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26519After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Write on a temporary table should not send request to TiKV
What is changed and how it works?
What's Changed:
Fix a bug introduced by #24196
I thought remove the temporary KV entries from the transaction buffer could avoid sending request to TiKV.
But I'm wrong. The
membuffer.Delete()API causes sending delete keys to TiKV ...How it Works:
Now I use the transaction
SetKVFilter()API to ignore the temporary table KV entries.See https://github.com/tikv/client-go/blob/b9e4cb538f3028c8a3cdaa6d04d6b47e2dcb322c/tikv/2pc.go#L357
Check List
Tests
Release note