Skip to content

store/tikv: point get use lite resolve lock#26560

Merged
ti-chi-bot merged 3 commits into
pingcap:release-5.0from
disksing:lite5.0
Aug 30, 2021
Merged

store/tikv: point get use lite resolve lock#26560
ti-chi-bot merged 3 commits into
pingcap:release-5.0from
disksing:lite5.0

Conversation

@disksing
Copy link
Copy Markdown
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Problem Summary: Point get does not use lite version of resolve lock any more. It was broken by previous code refactoring (#22732)

What is changed and how it works?

The fix is a cherry-pick of the client-go PR. (code in master branch is moved to standalone directory so we have to cherry-pick manually)

Check List

Tests

  • Unit test

Release note

  • Fix the issue that point get does not use lite version resolve lock

Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested review from AndreMouche and lysu July 26, 2021 08:41
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@zhouqiang-cl
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a2b5a87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2b9e7a4 into pingcap:release-5.0 Aug 30, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants