Skip to content

session,server: forbid stale read in local temporary tables#27270

Merged
ti-chi-bot merged 11 commits into
pingcap:masterfrom
sylzd:temp_table_25937_2
Aug 18, 2021
Merged

session,server: forbid stale read in local temporary tables#27270
ti-chi-bot merged 11 commits into
pingcap:masterfrom
sylzd:temp_table_25937_2

Conversation

@sylzd
Copy link
Copy Markdown
Contributor

@sylzd sylzd commented Aug 17, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25937

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 17, 2021
@github-actions github-actions Bot added the sig/execution SIG execution label Aug 17, 2021
@sylzd
Copy link
Copy Markdown
Contributor Author

sylzd commented Aug 17, 2021

/run-check_dev_2

1 similar comment
@sylzd
Copy link
Copy Markdown
Contributor Author

sylzd commented Aug 17, 2021

/run-check_dev_2

@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 17, 2021
@lcwangchao
Copy link
Copy Markdown
Collaborator

lcwangchao commented Aug 17, 2021

Why creating a new pr instead of #26976

lcwangchao
lcwangchao reviewed Aug 17, 2021
View reviewed changes
Comment thread planner/core/preprocess.go
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
@tiancaiamao tiancaiamao requested a review from lcwangchao August 17, 2021 08:27
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2021
@sylzd sylzd mentioned this pull request Aug 17, 2021
Closed
12 tasks
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Aug 18, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 18, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3fc0690

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@sylzd
Copy link
Copy Markdown
Contributor Author

sylzd commented Aug 18, 2021

/run-check_dev_2

@sylzd
Copy link
Copy Markdown
Contributor Author

sylzd commented Aug 18, 2021

/run-build

@ti-chi-bot ti-chi-bot merged commit 165e365 into pingcap:master Aug 18, 2021
@sylzd sylzd mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forbid stale read in local temporary tables

4 participants

@sylzd @ti-chi-bot @lcwangchao @tiancaiamao