server: do not overwrite the log of handshake error#27962
Merged
Conversation
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note
ti-chi-bot
added
the
size/XS
lysu
approved these changes
Sep 11, 2021
bb7133
approved these changes
Sep 11, 2021
ti-chi-bot
added
status/LGT2
Member
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3f94032 |
ti-chi-bot
added
the
status/can-merge
Contributor
|
/run-check_dev_2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
When handshake error occurs, if
conn.Close()return nil, the log of the handshake error will disappear.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Fix it.
Check List
Tests
Side effects
Documentation
Release note