ddl, util/codec: fix add index OOM and prevent panic in logging (#29925)

[ti-srebot]

cherry-pick #29925 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30123

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30123:release-5.1-d04a1285a54c

---

What problem does this PR solve?

Issue Number: close #27687

Reproducible step:

drop table if exists t;
create table t (a bigint primary key);
insert into t values (-9078130948872077313);
alter table t add index idx(a);

Problem Summary:

This problem may occur in the following conditions:

• The table contains an clustered integer primary key.
  • If it is unsigned, at least one large primary key(> MaxInt64) is explicitly inserted.
  • If it is signed, at least one small negative number is explicitly inserted.
• An adding index job is running.

There is a bug in the current implementation of NewCommonHandle():

tidb/kv/key.go

Lines 237 to 262 in 37bfd57

	// NewCommonHandle creates a CommonHandle from a encoded bytes which is encoded by code.EncodeKey.
	func NewCommonHandle(encoded []byte) (*CommonHandle, error) {
	ch := &CommonHandle{encoded: encoded}
	if len(encoded) < 9 {
	padded := make([]byte, 9)
	copy(padded, encoded)
	ch.encoded = padded
	}
	remain := encoded
	endOff := uint16(0)
	for len(remain) > 0 {
	if remain[0] == 0 {
	// padded data
	break
	}
	var err error
	var col []byte
	col, remain, err = codec.CutOne(remain)
	if err != nil {
	return nil, err
	}
	endOff += uint16(len(col))
	ch.colEndOffsets = append(ch.colEndOffsets, endOff)
	}
	return ch, nil
	}

If the argument bytes have a prefix like 0x8203, CutOne() cuts nothing so that the remain is unchanged in the loop. This dead loop may cause TiDB OOM quickly because it endlessly append() colEndOffsets.

What is changed and how it works?

1. The function peek() in the decoding process does not handle the invalid key. It is possible to run into a dead loop and makes TiDB OOM.
2. The function tryDecodeHandleToString() is only used for logging, it should be wrapped with recover() so that the critical operation is not interrupted.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix an issue that adding index panics by chance.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bb7133
• wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-srebot]

@tangenta you're already a collaborator in bot's repo.

[ti-chi-bot]

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

/run-check_dev

[bb7133]

/run-mysql-test

[bb7133]

/merge

[ti-chi-bot]

@bb7133: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 618d3de

[bb7133]

/run-check_dev

[bb7133]

/merge

[bb7133]

/merge

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.