Skip to content

expression: make built-in function ord() backward compatible#30177

Closed
tangenta wants to merge 4 commits into
pingcap:masterfrom
tangenta:ord-builtin-fix
Closed

expression: make built-in function ord() backward compatible#30177
tangenta wants to merge 4 commits into
pingcap:masterfrom
tangenta:ord-builtin-fix

Conversation

@tangenta
Copy link
Copy Markdown
Contributor

@tangenta tangenta commented Nov 26, 2021

What problem does this PR solve?

Related to #30156.

Problem Summary:

select ord(_latin1 '');

should not return an encoding error.

Previous ord() implementation did not consider the backward compatibility. The test TestStringBuiltin was skipped due to the test framework refactoring. Now we add it back.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@Defined2014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta
Copy link
Copy Markdown
Contributor Author

cc @unconsolable

@ti-chi-bot
Copy link
Copy Markdown
Member

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta tangenta requested a review from zimulala December 1, 2021 08:19
@hawkingrei
Copy link
Copy Markdown
Member

/run-check_dev_2

@tangenta
Copy link
Copy Markdown
Contributor Author

tangenta commented Dec 7, 2021

It will be fixed in #30288.

@tangenta tangenta closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants