Skip to content

lightning: fix gcs max key limit (#30393)#30560

Merged
ti-chi-bot merged 7 commits into
pingcap:release-5.3from
ti-srebot:release-5.3-bc08b50127f5
Feb 18, 2022
Merged

lightning: fix gcs max key limit (#30393)#30560
ti-chi-bot merged 7 commits into
pingcap:release-5.3from
ti-srebot:release-5.3-bc08b50127f5

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Dec 9, 2021 •
edited
Loading

cherry-pick #30393 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30560

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30560:release-5.3-bc08b50127f5

What problem does this PR solve?

Issue Number: close #30377

Problem Summary: opt.ListCount is the number of keys fetched each time for s3, instead of the limitation.

What is changed and how it works?

ignore opt.ListCount in gcs and directly walk all the keys.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Leavrth @ti-srebot
cherry pick pingcap#30393 to release-5.3
cbc9e3b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Dec 9, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 9, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 9, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 9, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Dec 9, 2021

@Leavrth please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 15, 2022
@lichunzhu
Copy link
Copy Markdown
Contributor

lichunzhu commented Feb 18, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 18, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: cbc9e3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2022
@lichunzhu
Copy link
Copy Markdown
Contributor

lichunzhu commented Feb 18, 2022

/run-check_dev

1 similar comment
@lichunzhu
Copy link
Copy Markdown
Contributor

lichunzhu commented Feb 18, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 33876a3 into pingcap:release-5.3 Feb 18, 2022
@lichunzhu lichunzhu deleted the release-5.3-bc08b50127f5 branch February 18, 2022 07:08
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

@july2993 july2993 Awaiting requested review from july2993

Assignees

@Leavrth Leavrth

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

8 participants

@ti-srebot @ti-chi-bot @lichunzhu @kennytm @glorv @purelind @zhouqiang-cl @Leavrth