Skip to content

execute: Revert "execute: don't transform charset in internal sql" and fix #30947

Closed
hawkingrei wants to merge 2 commits into
masterfrom
revert-30843-30789
Closed

execute: Revert "execute: don't transform charset in internal sql" and fix #30947
hawkingrei wants to merge 2 commits into
masterfrom
revert-30843-30789

Conversation

@hawkingrei
Copy link
Copy Markdown
Member

@hawkingrei hawkingrei commented Dec 22, 2021 •
edited
Loading

Reverts #30843

Issue Number: close #30918

Release note

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 22, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2021
@hawkingrei hawkingrei changed the title Revert "execute: don't transform charset in internal sql" execute: Revert "execute: don't transform charset in internal sql" Dec 22, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2021
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Dec 22, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2ad1b5ec65f10f414b3790bbb2a8fc269f7ebd8c

@hawkingrei
*: replace sessionctx.Context with sys_session
2ad1b5e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title execute: Revert "execute: don't transform charset in internal sql" execute: Revert "execute: don't transform charset in internal sql" and fix Dec 22, 2021
@hawkingrei hawkingrei added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 31, 2021

@hawkingrei: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2021
@hawkingrei hawkingrei closed this Jan 22, 2022
@tisonkun tisonkun deleted the revert-30843-30789 branch February 22, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DATA RACE in the SessionVars.InRestrictedSQL

3 participants

@hawkingrei @ti-chi-bot @sre-bot