Skip to content

ddl: support specifying expr uuid() as column default value.#33871

Merged
ti-chi-bot merged 9 commits into
pingcap:masterfrom
CbcWestwolf:default_uuid_expr
Apr 13, 2022
Merged

ddl: support specifying expr uuid() as column default value.#33871
ti-chi-bot merged 9 commits into
pingcap:masterfrom
CbcWestwolf:default_uuid_expr

Conversation

@CbcWestwolf
Copy link
Copy Markdown
Member

@CbcWestwolf CbcWestwolf commented Apr 11, 2022

What problem does this PR solve?

Issue Number: close #33870

Problem Summary:

MySQL 8.0 supports specifying uuid() as a column's default value when creating table.

What is changed and how it works?

Add ast.UUID in getFuncCallDefaultValue function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2022
@purelind
Copy link
Copy Markdown
Contributor

purelind commented Apr 12, 2022

/run-unit-test

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/22e9d25b2418324fa3c1a3994383450c23c86cc3

Defined2014
Defined2014 reviewed Apr 12, 2022
View reviewed changes
Comment thread ddl/db_integration_test.go
tk.MustExec("drop table if exists t")

// create table
tk.MustExec("create table t (c int(10), c1 varchar(256) default (uuid()))")
Copy link
Copy Markdown
Contributor

@Defined2014 Defined2014 Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test for show create table t

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
tangenta
tangenta reviewed Apr 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments reveal nothing, let's remove them.

Rest LGTM

Comment thread ddl/db_integration_test.go Outdated
Comment thread ddl/db_integration_test.go Outdated
Comment thread ddl/db_integration_test.go Outdated
Comment thread ddl/db_integration_test.go Outdated
CbcWestwolf and others added 2 commits April 13, 2022 16:03
@CbcWestwolf @tangenta
Update ddl/db_integration_test.go
dd51094 
Co-authored-by: tangenta <tangenta@126.com>
@CbcWestwolf @tangenta
Update ddl/db_integration_test.go
76741de 
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2022
CbcWestwolf and others added 3 commits April 13, 2022 16:03
@CbcWestwolf @tangenta
Update ddl/db_integration_test.go
ea31c1b 
Co-authored-by: tangenta <tangenta@126.com>
@CbcWestwolf @tangenta
Update ddl/db_integration_test.go
02698e6 
Co-authored-by: tangenta <tangenta@126.com>
@CbcWestwolf
Merge branch 'master' into default_uuid_expr
7db2f28
@CbcWestwolf CbcWestwolf requested a review from tangenta April 13, 2022 08:43
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@tangenta
Copy link
Copy Markdown
Contributor

tangenta commented Apr 13, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7db2f28

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@ti-chi-bot ti-chi-bot merged commit d3e076c into pingcap:master Apr 13, 2022
@CbcWestwolf CbcWestwolf deleted the default_uuid_expr branch April 13, 2022 15:04
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 13, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 5, success 29, total 34 18 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 9, total 11 13 min New failing
idc-jenkins-ci-tidb/integration-br-test 🟢 all 29 tests passed 45 min Existing passed
idc-jenkins-ci-tidb/code-coverage 🟢 Lines coverage: 63.48% 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 57 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 47 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 45 sec Existing passed
idc-jenkins-ci-tidb/integration-copr-test 🟢 all 1 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 40 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 28 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 29 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support specifying expr uuid() as column default value

6 participants

@CbcWestwolf @ti-chi-bot @purelind @sre-bot @tangenta @Defined2014