Skip to content

*: Revert #33519 for performance fallback and fix the #33509 in another way#34425

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
lcwangchao:revert_33519
May 6, 2022
Merged

*: Revert #33519 for performance fallback and fix the #33509 in another way#34425
ti-chi-bot merged 1 commit into
pingcap:masterfrom
lcwangchao:revert_33519

Conversation

@lcwangchao
Copy link
Copy Markdown
Collaborator

@lcwangchao lcwangchao commented May 6, 2022 •
edited
Loading

This reverts commit 5004a81.

What problem does this PR solve?

Issue Number: close #33509

Problem Summary:

What is changed and how it works?

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 6, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9e071a02ec980aee40ac1d15981ad1239e3f544e

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@lcwangchao
Copy link
Copy Markdown
Collaborator Author

lcwangchao commented May 6, 2022

/rebuild

@lcwangchao
Copy link
Copy Markdown
Collaborator Author

lcwangchao commented May 6, 2022

/run-mysql-test

@cfzjywxk
Copy link
Copy Markdown
Contributor

cfzjywxk commented May 6, 2022

Need a unit test to cover the issue situation.

@lcwangchao lcwangchao changed the title *: Revert #33519 for performance fallback and fix the #33509 in anoth… *: Revert #33519 for performance fallback and fix the #33509 in another way May 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2022
@cfzjywxk
Copy link
Copy Markdown
Contributor

cfzjywxk commented May 6, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 6, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9e071a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@ti-chi-bot ti-chi-bot merged commit 1f9d34a into pingcap:master May 6, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-4.0
4e2b679 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-4.0 in PR #34428

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-5.0
a29b15f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-5.0 in PR #34429

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-5.1
655fded 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-5.1 in PR #34430

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-5.2
0408e08 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-5.2 in PR #34431

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-5.3
e6e5194 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Merged
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-5.3 in PR #34432

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#34425 to release-5.4
9e4ef54 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Merged
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-5.4 in PR #34433

@lcwangchao lcwangchao deleted the revert_33519 branch May 6, 2022 13:33
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented May 6, 2022

cherry pick to release-6.0 failed

ti-chi-bot pushed a commit that referenced this pull request May 6, 2022
@ti-srebot
*: Revert #33519 for performance fallback and fix the #33509 in anoth…
f604940 
…er way (#34425) (#34433)

close #33509
ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2022
@ti-srebot
*: Revert #33519 for performance fallback and fix the #33509 in anoth…
d4f1d2d 
…er way (#34425) (#34432)

close #33509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

execute prepared statement with binary protocol will panic when table schema changed

6 participants

@lcwangchao @ti-chi-bot @sre-bot @cfzjywxk @ti-srebot @tiancaiamao