Skip to content

ddl: invalid multiple MAXVALUE partitions (#36329) (#36345)#36445

Merged
ti-chi-bot merged 7 commits into
pingcap:release-5.4from
ti-srebot:release-5.4-121a6669a85c
Aug 4, 2022
Merged

ddl: invalid multiple MAXVALUE partitions (#36329) (#36345)#36445
ti-chi-bot merged 7 commits into
pingcap:release-5.4from
ti-srebot:release-5.4-121a6669a85c

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jul 21, 2022

cherry-pick #36345 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36445

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36445:release-5.4-121a6669a85c

Signed-off-by: u5surf u5.horie@gmail.com

What problem does this PR solve?

Issue Number: close #36329

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release-note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 21, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.4-cherry-pick labels Jul 21, 2022
@ti-srebot ti-srebot requested review from Defined2014 and mjonss July 21, 2022 17:03
@ti-srebot ti-srebot added this to the v5.4.1 milestone Jul 21, 2022
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@Defined2014 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
xhebox added 2 commits July 27, 2022 15:52
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@mjonss
Copy link
Copy Markdown
Contributor

mjonss commented Jul 27, 2022

/run-unit-test

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 27, 2022

@Defined2014
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7ed405b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

1 similar comment
@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 1b399aa into pingcap:release-5.4 Aug 4, 2022
@xhebox xhebox deleted the release-5.4-121a6669a85c branch August 4, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants