Skip to content

doc: add batch coprocessor rfc#39362

Merged
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
cfzjywxk:batch_cop_rfc
Jan 31, 2024
Merged

doc: add batch coprocessor rfc#39362
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
cfzjywxk:batch_cop_rfc

Conversation

@cfzjywxk
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #39361

Problem Summary:
The design docuement.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2022
Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the table worker gets a coprocessor task, it would split the handle ranges according to th�e region
When the table worker gets a coprocessor task, it would split the handle ranges according to the region

Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"required"?

Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repeated type is missing.

Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to collect errors with region id or task info. e.g., 100 region tasks request got 2 errors(the first and last), we need to tell TiDB which tasks need to be retried.

Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Comment thread docs/design/2022-11-23-batch-cop.md Outdated
Comment thread docs/design/2022-11-23-batch-cop.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2023

Codecov Report

Merging #39362 (b732365) into master (d62ba73) will increase coverage by 2.8814%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head b732365 differs from pull request most recent head d4cb1f3. Consider uploading reports for the commit d4cb1f3 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #39362        +/-   ##
================================================
+ Coverage   70.5286%   73.4101%   +2.8814%     
================================================
  Files          1465       1056       -409     
  Lines        433686     335891     -97795     
================================================
- Hits         305873     246578     -59295     
+ Misses       108604      73518     -35086     
+ Partials      19209      15795      -3414     

@cfzjywxk cfzjywxk requested review from ekexium and you06 January 31, 2024 03:53
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 31, 2024
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 31, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 06:21:25.567833873 +0000 UTC m=+1546527.132131577: ☑️ agreed by zyguan.
  • 2024-01-31 07:39:32.269276707 +0000 UTC m=+1551213.833574398: ☑️ agreed by you06.

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Jan 31, 2024

@cfzjywxk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test b732365f2220125654079cae7c1a00ae6c0d8ca0 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cfzjywxk
Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 31, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,you06,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfzjywxk
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Jan 31, 2024

@cfzjywxk: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cfzjywxk and others added 7 commits January 31, 2024 16:07
@ti-chi-bot ti-chi-bot Bot merged commit 732fa8c into pingcap:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/docs lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants