ddl: gc mdl etcd key after cleaning the mdl table#39454
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
hawkingrei
approved these changes
Nov 29, 2022
lcwangchao
approved these changes
Nov 30, 2022
Member
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3a58b89 |
Member
Author
|
/run-all-tests |
1 similar comment
Member
Author
|
/run-all-tests |
Member
Author
|
/run-unit-test |
Contributor
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Problem Summary:
We should gc mdl etcd key after cleaning the mdl table.
Otherwise, ddl may be blocked if the owner crash before cleaning the mdl table and the etcd key is gced
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.