planner: refactor to put all plan-cacheability-check functions together (#40625)#41445
Merged
ti-chi-bot merged 2 commits intoFeb 17, 2023
Merged
Conversation
12 tasks
Member
Author
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
force-pushed
the
cherry-pick-40625-to-release-6.5
branch
from
38cc21a to
3c9f0bb
Compare
ti-chi-bot
removed
the
needs-rebase
qw4990
approved these changes
Feb 17, 2023
fzzf678
approved these changes
Feb 17, 2023
ti-chi-bot
added
status/LGT2
Reminiscent
approved these changes
Feb 17, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
force-pushed
the
cherry-pick-40625-to-release-6.5
branch
from
fcd196e to
f4f51e5
Compare
VelocityLight
added
cherry-pick-approved
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: f4f51e5 |
ti-chi-bot
added
the
status/can-merge
Contributor
|
/retest |
ti-chi-bot
removed
the
status/can-merge
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 089c485 |
ti-chi-bot
added
the
status/can-merge
Contributor
|
/test unit-test |
Contributor
|
/merge |
2 similar comments
Contributor
|
/merge |
Contributor
|
/merge |
Contributor
|
/merge |
1 similar comment
Contributor
|
/merge |
Contributor
|
/test check-dev2 |
VelocityLight
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
VelocityLight
added
cherry-pick-approved
VelocityLight
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #40625
What problem does this PR solve?
Issue Number: ref #38335
Problem Summary: planner: refactor to put all plan-cacheability-check functions together
What is changed and how it works?
No logical change, just refactor that put all plan-cacheability-check functions together.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.