Skip to content

ddl: Added tests for Reorganize Partition with TiFlash#42082

Merged
ti-chi-bot[bot] merged 214 commits into
pingcap:masterfrom
mjonss:reorg-part-tiflash-tests
May 15, 2023
Merged

ddl: Added tests for Reorganize Partition with TiFlash#42082
ti-chi-bot[bot] merged 214 commits into
pingcap:masterfrom
mjonss:reorg-part-tiflash-tests

Conversation

@mjonss
Copy link
Copy Markdown
Contributor

@mjonss mjonss commented Mar 9, 2023

What problem does this PR solve?

Issue Number: ref #38535

Problem Summary:
Alternative instead of #40715 (i.e. less changes to logic, but still includes the tests).

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

mjonss and others added 30 commits October 3, 2022 12:58
@mjonss
WIP: Support REORGANIZE PARTITION
cddba93
@mjonss
ddl: support modify column on partitioned table
4013303
@mjonss
Fixed tests
a8a0d2c
@mjonss
Merge remote-tracking branch 'pingcap/master' into allow-mod-col-on-part
8ada652
@mjonss
WIP reorganize partition
2458678
@mjonss
Merge branch 'allow-mod-col-on-part' into reorganize-partition
d7437c5
@mjonss
WIP starting to work \o/
6bc2909
@mjonss
Updated test
9adfd25
@mjonss
Test update
5356f77
@mjonss
Fixed some issues
913e503 
Currently the last test case fails, so it is disabled.

It seems like it tries to read data from the wrong partition...
@mjonss
Lint fix
f42852f
@mjonss
Fixed linting
20a98ea
@mjonss
Only do DroppingDefinitions during REORG PARTITION
2bfe6dd
@mjonss
Fixed linting
dad8b4f
@mjonss
cleanups
cccbe8b
@mjonss
Fix for modify column
978afda
@mjonss
Test passes
75c94ed
@mjonss
Updated test
9e3bdf8
@mjonss
Fixed restriction on new end-range
de8cce8
@mjonss
lint fix
be7643f
@mjonss
Tested LIST partitioning
aa859a2
@mjonss
lint fixes
ea6354f
@mjonss
added schema to backgroundExec test function
38c6d09
@mjonss
First part of REORGANIZE PARTITION, implementing data/index copying
b39dacc 
Merge commit '38c6d09493cb632bbe179aabca4d973e8ccb56eb' into reorg-part-data-reorg
@mjonss @xiongjiwei @Yisaer
Merge master into feature branch (pingcap#38463)
0d316ef 
* mockkv: make pk id = -1 if no primary key column is used (pingcap#38443)

* ddl: support modify column on partitioned table (pingcap#38302)

close pingcap#38297

* planner: revise isnullRejected check for `And` and `OR` (pingcap#38430)

close pingcap#38304

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: Song Gao <disxiaofei@163.com>
@mjonss
Merge remote-tracking branch 'pingcap/feature/reorganize-partition' i…
a49abe0 
…nto reorg-part-data-reorg
@mjonss
Code cleanups
3d72072
@mjonss
Cleaned up an issue with 38302
6bd0fe1
@mjonss
Changed the interface for partition and partitioned table
711f5d5
@mjonss
Added GetPartitionedTable to Table interface
9c22c96
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 9, 2023 •
edited by ti-chi-bot Bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2023
@mjonss mjonss mentioned this pull request Mar 12, 2023
Closed
12 tasks
@mjonss
Copy link
Copy Markdown
Contributor Author

mjonss commented Mar 12, 2023

/test build

crazycs520
crazycs520 reviewed May 8, 2023
View reviewed changes
Comment thread ddl/partition.go
bb7133
bb7133 reviewed May 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address the comment from @crazycs520

@mjonss
Copy link
Copy Markdown
Contributor Author

mjonss commented May 10, 2023

@crazycs520 & @bb7133 I've updated the PR and adressed your comments, PTAL.

bb7133
bb7133 approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2023
crazycs520
crazycs520 approved these changes May 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@mjonss
Copy link
Copy Markdown
Contributor Author

mjonss commented May 15, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 15, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 92da0e2

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2023
@ti-chi-bot ti-chi-bot Bot merged commit 9019f78 into pingcap:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjonss @ti-chi-bot @bb7133 @crazycs520