Skip to content

conn, util: make opentracing work again (#50551)#50557

Closed
ti-chi-bot wants to merge 1 commit into
pingcap:release-7.5from
ti-chi-bot:cherry-pick-50551-to-release-7.5
Closed

conn, util: make opentracing work again (#50551)#50557
ti-chi-bot wants to merge 1 commit into
pingcap:release-7.5from
ti-chi-bot:cherry-pick-50551-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #50551

What problem does this PR solve?

Issue Number: close #50508

Problem Summary: Caused by #40825, miss root span for opentracing tools.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Start a TiDB cluster as opentracing.enable not work after v7.1.0 #50508 said, and use JaegerUI to get trace info success.
    image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 18, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 18, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 18, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 0f03b66 link true /test check-dev2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@3f84f3f). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50557   +/-   ##
================================================
  Coverage               ?   71.9704%           
================================================
  Files                  ?       1400           
  Lines                  ?     406617           
  Branches               ?          0           
================================================
  Hits                   ?     292644           
  Misses                 ?      94282           
  Partials               ?      19691           
Flag Coverage Δ
unit 71.9704% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2715% <0.0000%> (?)

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-21 06:56:13.06310141 +0000 UTC m=+684614.627399099: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot closed this Feb 6, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-50551-to-release-7.5 branch April 15, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants