Skip to content

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Mar 19, 2025

What problem does this PR solve?

Issue Number: ref #59925

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Mar 19, 2025
@tiprow
Copy link

tiprow bot commented Mar 19, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1377%. Comparing base (80d6b56) to head (5a5a993).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60177        +/-   ##
================================================
+ Coverage   73.1532%   75.1377%   +1.9844%     
================================================
  Files          1707       1724        +17     
  Lines        471640     475182      +3542     
================================================
+ Hits         345020     357041     +12021     
+ Misses       105441      96361      -9080     
- Partials      21179      21780       +601     
Flag Coverage Δ
integration 46.6268% <ø> (?)
unit 72.8217% <ø> (+0.2017%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (∅)
parser ∅ <ø> (∅)
br 62.3912% <ø> (+14.3297%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@BornChanger
Copy link
Contributor

/retest

@tiprow
Copy link

tiprow bot commented Mar 20, 2025

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-19 10:48:13.740606712 +0000 UTC m=+438987.424843103: ☑️ agreed by BornChanger.
  • 2025-03-21 05:30:50.312750274 +0000 UTC m=+592743.996986370: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit ad7df79 into pingcap:master Mar 21, 2025
34 checks passed
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants