Skip to content

Conversation

@Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Mar 28, 2025

What problem does this PR solve?

Issue Number: close #60329

Problem Summary:

What changed and how does it work?

Turn off both backup and restore checksum by default
Default turned on by int test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

We previously turned off backup checksum by default and this PR turns off restore checksum by default as well as we think it's resource intensive in production. User can still turn it on by enabling the flag explicitly. 

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900 Tristan1900 changed the title br set default restore checksum to false br: set default restore checksum to false Mar 28, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/invalid-title do-not-merge/needs-tests-checked labels Mar 28, 2025
@tiprow
Copy link

tiprow bot commented Mar 28, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.2819%. Comparing base (9518131) to head (f6d0131).
Report is 65 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60328        +/-   ##
================================================
+ Coverage   73.1030%   76.2819%   +3.1788%     
================================================
  Files          1710       1730        +20     
  Lines        472551     490537     +17986     
================================================
+ Hits         345449     374191     +28742     
+ Misses       105816      94831     -10985     
- Partials      21286      21515       +229     
Flag Coverage Δ
integration 47.8251% <40.0000%> (?)
unit 74.0375% <60.0000%> (+1.7373%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.8593% <ø> (+2.1683%) ⬆️
parser ∅ <ø> (∅)
br 62.6178% <50.0000%> (+15.3837%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 31, 2025
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-02 02:03:07.932610872 +0000 UTC m=+1617081.616846963: ☑️ agreed by Leavrth.
  • 2025-04-11 03:40:46.836034019 +0000 UTC m=+2400540.520270115: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 4d34cac into pingcap:master Apr 11, 2025
27 of 29 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

br: set default restore checksum to false

3 participants