placement: fix alter meta range cannot work by nolouch · Pull Request #60889 · pingcap/tidb

nolouch · 2025-04-28T03:50:35Z

What problem does this PR solve?

Issue Number: close #60888

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

codecov · 2025-04-28T04:09:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.4272%. Comparing base (e8fb24a) to head (b448ad4).
Report is 400 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60889        +/-   ##
================================================
+ Coverage   73.1316%   76.4272%   +3.2955%     
================================================
  Files          1719       1770        +51     
  Lines        476215     503794     +27579     
================================================
+ Hits         348264     385036     +36772     
+ Misses       106583      95990     -10593     
- Partials      21368      22768      +1400

Flag	Coverage Δ
integration	`50.6255% <0.0000%> (?)`
unit	`73.9712% <100.0000%> (+1.6200%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.0684% <ø> (+0.3566%)`	⬆️
parser	`∅ <ø> (∅)`
br	`65.4244% <ø> (+18.0701%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nolouch · 2025-04-28T06:44:53Z

/retest-required

Signed-off-by: nolouch <nolouch@gmail.com>

zimulala

LGTM

nolouch · 2025-04-29T03:01:11Z

/retest-required

nolouch · 2025-04-29T03:50:21Z

/test unit-test

tiprow · 2025-04-29T03:50:26Z

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

tidb_parser_test

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nolouch · 2025-04-29T08:40:50Z

/retest-required

nolouch · 2025-04-29T09:33:53Z

/test fast_test_tiprow

ti-chi-bot · 2025-04-29T09:33:56Z

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-next-gen-real-tikv-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_lightning_integration_test

pingcap/tidb/pull_mysql_client_test

pingcap/tidb/pull_unit_test_ddlv1

Details

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-04-29T09:34:11Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-next-gen-real-tikv-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_unit_test_ddlv1
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nolouch · 2025-05-06T03:09:45Z

/test fast_test_tiprow

ti-chi-bot · 2025-05-06T03:09:48Z

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-next-gen-real-tikv-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_lightning_integration_test

pingcap/tidb/pull_mysql_client_test

pingcap/tidb/pull_unit_test_ddlv1

Details

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-05-06T03:10:02Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-next-gen-real-tikv-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_unit_test_ddlv1
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-05-12T09:18:01Z

[LGTM Timeline notifier]

Timeline:

2025-04-28 11:17:50.971994248 +0000 UTC m=+872814.783784626: ☑️ agreed by zimulala.
2025-05-12 09:18:01.426308695 +0000 UTC m=+350347.574269912: ☑️ agreed by rleungx.

ti-chi-bot · 2025-05-13T03:44:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/ddl/OWNERS~~ [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nolouch · 2025-05-13T06:16:11Z

/run-cherry-picker

ti-chi-bot · 2025-05-13T06:17:04Z

In response to a cherrypick label: new pull request created to branch release-8.5: #61090.

nolouch · 2025-07-02T18:23:41Z

/run-cherry-picker

ti-chi-bot · 2025-07-02T18:24:09Z

In response to a cherrypick label: new pull request created to branch release-8.1: #62167.

ti-chi-bot · 2025-07-02T18:24:13Z

In response to a cherrypick label: new pull request created to branch release-7.5: #62168.

close #60888

…61090) (pingcap#284)

…61090) X-Original-Commit: b6a6e7336ba663549af921e420784b99950289d5

ti-chi-bot Bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2025

ti-chi-bot Bot removed the do-not-merge/needs-triage-completed label Apr 28, 2025

nolouch force-pushed the fix-meta-range branch from 2e3d1f6 to b932332 Compare April 28, 2025 07:05

placement: fix alter meta range cannot work

b448ad4

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the fix-meta-range branch from b932332 to b448ad4 Compare April 28, 2025 10:15

zimulala approved these changes Apr 28, 2025

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 28, 2025

nolouch requested a review from rleungx May 6, 2025 03:32

rleungx approved these changes May 12, 2025

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 12, 2025

tangenta approved these changes May 13, 2025

View reviewed changes

ti-chi-bot Bot added the approved label May 13, 2025

ti-chi-bot Bot merged commit c4ff9c3 into pingcap:master May 13, 2025
27 checks passed

nolouch deleted the fix-meta-range branch May 13, 2025 06:15

nolouch added affects-8.5 This bug affects the 8.5.x(LTS) versions. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed affects-8.5 This bug affects the 8.5.x(LTS) versions. labels May 13, 2025

ti-chi-bot mentioned this pull request May 13, 2025

placement: fix alter meta range cannot work (#60889) #61090

Merged

5 tasks

nolouch added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 2, 2025

ti-chi-bot mentioned this pull request Jul 2, 2025

placement: fix alter meta range cannot work (#60889) #62167

Open

5 tasks

ti-chi-bot mentioned this pull request Jul 2, 2025

placement: fix alter meta range cannot work (#60889) #62168

Merged

5 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Jul 14, 2025

placement: fix alter meta range cannot work (#60889) (#61090)

f2490ea

close #60888

ti-chi-bot Bot pushed a commit that referenced this pull request Jul 17, 2025

placement: fix alter meta range cannot work (#60889) (#62168)

eae2045

close #60888

AvaisP added a commit to AvaisP/tidb that referenced this pull request Mar 2, 2026

placement: fix alter meta range cannot work (pingcap#60889) (pingcap#…

747a120

…61090) (pingcap#284)

AvaisP added a commit to AvaisP/tidb that referenced this pull request Mar 2, 2026

placement: fix alter meta range cannot work (pingcap#60889) (pingcap#…

828cebf

…61090) (pingcap#284)

AvaisP added a commit to AvaisP/tidb that referenced this pull request Mar 4, 2026

placement: fix alter meta range cannot work (pingcap#60889) (pingcap#…

0e5fe27

…61090) (pingcap#284)

ClamChowderTiDB added a commit to ClamChowderTiDB/tidb that referenced this pull request Mar 31, 2026

placement: fix alter meta range cannot work (pingcap#60889) (pingcap#…

f7e0529

…61090) X-Original-Commit: b6a6e7336ba663549af921e420784b99950289d5

Conversation

nolouch commented Apr 28, 2025

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

codecov Bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nolouch commented Apr 28, 2025

Uh oh!

zimulala left a comment

Choose a reason for hiding this comment

Uh oh!

nolouch commented Apr 29, 2025

Uh oh!

nolouch commented Apr 29, 2025

Uh oh!

tiprow Bot commented Apr 29, 2025

Uh oh!

nolouch commented Apr 29, 2025

Uh oh!

nolouch commented Apr 29, 2025

Uh oh!

ti-chi-bot Bot commented Apr 29, 2025

Uh oh!

tiprow Bot commented Apr 29, 2025

Uh oh!

nolouch commented May 6, 2025

Uh oh!

ti-chi-bot Bot commented May 6, 2025

Uh oh!

tiprow Bot commented May 6, 2025

Uh oh!

ti-chi-bot Bot commented May 12, 2025

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot Bot commented May 13, 2025

Uh oh!

Uh oh!

nolouch commented May 13, 2025

Uh oh!

ti-chi-bot commented May 13, 2025

Uh oh!

nolouch commented Jul 2, 2025

Uh oh!

ti-chi-bot commented Jul 2, 2025

Uh oh!

ti-chi-bot commented Jul 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Apr 28, 2025 •

edited

Loading