Skip to content

planner,ddl: rightly fix issue of add foreign key too slow in big table#61945

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hawkingrei:40111_2
Jun 24, 2025
Merged

planner,ddl: rightly fix issue of add foreign key too slow in big table#61945
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hawkingrei:40111_2

Conversation

@hawkingrei
Copy link
Copy Markdown
Member

@hawkingrei hawkingrei commented Jun 23, 2025

What problem does this PR solve?

Issue Number: ref #40111

Problem Summary:

What changed and how does it work?

Old bugfix has problem. The root cause is the uninit system variable.

Check List

Tests

  • Unit test

in the origin Bugfix PRTestAddForeignKeyInBigTable is for testing this problem.

  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jun 23, 2025
@hawkingrei hawkingrei requested a review from crazycs520 June 23, 2025 15:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5456%. Comparing base (1b35bd0) to head (fc11e9a).
Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61945        +/-   ##
================================================
+ Coverage   72.9655%   75.5456%   +2.5800%     
================================================
  Files          1735       1781        +46     
  Lines        481848     495682     +13834     
================================================
+ Hits         351583     374466     +22883     
+ Misses       108725      98349     -10376     
- Partials      21540      22867      +1327     
Flag Coverage Δ
integration 49.3520% <100.0000%> (?)
unit 72.8230% <100.0000%> (+0.6141%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 64.2186% <ø> (+17.6266%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 24, 2025
@hawkingrei hawkingrei changed the title planner: rightly fix issue of add foreign key too slow in big table planner,ddl: rightly fix issue of add foreign key too slow in big table Jun 24, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 24, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-24 02:30:38.293585405 +0000 UTC m=+757291.016764382: ☑️ agreed by crazycs520.
  • 2025-06-24 06:15:01.057599836 +0000 UTC m=+770753.780778813: ☑️ agreed by tangenta.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 24, 2025
@hawkingrei
Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot ti-chi-bot Bot merged commit dbb2c9c into pingcap:master Jun 24, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants