planner,ddl: rightly fix issue of add foreign key too slow in big table#61945
Merged
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61945 +/- ##
================================================
+ Coverage 72.9655% 75.5456% +2.5800%
================================================
Files 1735 1781 +46
Lines 481848 495682 +13834
================================================
+ Hits 351583 374466 +22883
+ Misses 108725 98349 -10376
- Partials 21540 22867 +1327
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
crazycs520
approved these changes
Jun 24, 2025
tangenta
approved these changes
Jun 24, 2025
[LGTM Timeline notifier]Timeline:
|
yudongusa
approved these changes
Jun 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #40111
Problem Summary:
What changed and how does it work?
Old bugfix has problem. The root cause is the uninit system variable.
Check List
Tests
in the origin Bugfix PR,
TestAddForeignKeyInBigTableis for testing this problem.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.