tables: force to lock the touched index in DML when DDL merging temp index (#62387)#62400
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@lcwangchao This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #62400 +/- ##
================================================
Coverage ? 57.4239%
================================================
Files ? 1779
Lines ? 633819
Branches ? 0
================================================
Hits ? 363964
Misses ? 245785
Partials ? 24070
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #62387
What problem does this PR solve?
Issue Number: close #62337
Problem Summary:
see descriptions in issue. We choose the second way to fix it.
What changed and how does it work?
When the index is in state
BackfillStateReadyToMergeorBackfillStateMerging, we also lock the touched non-unique indices to ensure the correctness, even if the DDL does not lock the row.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.